Skip to content

Conversation

@nayyirahsan
Copy link

Converts all examples in examples/kokkos/ from the deprecated workload/functor style to the modern standalone style as requested in issue #351 (part of the broader deprecation effort #326).

@IvanGrigorik IvanGrigorik self-requested a review January 23, 2026 19:20
Copy link
Collaborator

@IvanGrigorik IvanGrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG, besides my comment above
You should also do the proper formatting (all files should end with \n)

@gliga
Copy link
Contributor

gliga commented Jan 25, 2026

Mostly LG, besides my comment above You should also do the proper formatting (all files should end with \n)

I hope that our CI checks this

@IvanGrigorik
Copy link
Collaborator

Mostly LG, besides my comment above You should also do the proper formatting (all files should end with \n)

I hope that our CI checks this

Yes, that's why formatting CI fails:
https://github.com/kokkos/pykokkos/actions/runs/21275692811/job/61309485939?pr=355#step:5:657

@IvanGrigorik IvanGrigorik changed the title Convert kokkos examples to standalone style (#351) examples: kokkos examples conversion (workload to workunit) Jan 25, 2026
@IvanGrigorik
Copy link
Collaborator

@nayyirahsan CIs are still failing.
Please, check out black formatter tool and format your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants