Require P3222 and P3050 #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P3222 (Fix C++26 by adding transposed special cases for P2642 layouts) was voted into C++26. Thus, we have removed the corresponding CMake option and macro LINALG_FIX_TRANSPOSED_FOR_PADDED_LAYOUTS .
P3050 ("Fix conjugated for noncomplex value types") was voted
into C++26. Thus we have removed the corresponding CMake option
and macro LINALG_FIX_CONJUGATED_FOR_NONCOMPLEX .
youyu3
approved these changes
Jan 26, 2026
Contributor
youyu3
left a comment
youyu3
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks Mark!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P3050 ("Fix conjugated for noncomplex value types") and P3222 ("Fix C++26 by adding transposed special cases for P2642 layouts") were voted into C++26. Thus, we have removed the corresponding CMake options and macros.
For P3050:
LINALG_FIX_CONJUGATED_FOR_NONCOMPLEXFor P3222:
LINALG_FIX_TRANSPOSED_FOR_PADDED_LAYOUTS