Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize over basic types, expose more methods for VCs #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Generalize over basic types, expose more methods for VCs #2

wants to merge 5 commits into from

Conversation

sigrlami
Copy link
Member

  • Adds DID generalization and expose a function to be used in VCs library or by any other 3rd party service.
  • Adds test validation to cross-check correctness with existing libraries

@sigrlami sigrlami self-assigned this Jan 15, 2021
@sigrlami sigrlami added the enhancement New feature or request label Jan 15, 2021
@sigrlami sigrlami changed the title Generalize over basic types, expose more methods for VCs WIP: Generalize over basic types, expose more methods for VCs Jan 15, 2021
@sigrlami sigrlami marked this pull request as draft January 15, 2021 13:20
@sigrlami sigrlami requested a review from maxbull January 19, 2021 15:10
@sigrlami sigrlami marked this pull request as ready for review January 19, 2021 15:11
@sigrlami sigrlami changed the title WIP: Generalize over basic types, expose more methods for VCs Generalize over basic types, expose more methods for VCs Jan 19, 2021
@sigrlami
Copy link
Member Author

@maxbull validate function runs python and golang libraries, please test and verify from Go side that they are interchangeable. I tested with Python lib only as of now.

@maxbull
Copy link

maxbull commented Jan 20, 2021

@sigrlami deactivate function not working for some reason. There are couple things to improve in a script running go, will push to branch.

maxbull
maxbull suggested changes Jan 20, 2021
View reviewed changes
Copy link

@maxbull maxbull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, needs correction in generation phase, looks like deactive uses wrong keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbull maxbull maxbull requested changes

Assignees

@sigrlami sigrlami

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigrlami @maxbull