sast-shell-check: set ShellCheck jobs based on cgroup v2 CPU limits #2506
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfowl
force-pushed
the
shellcheck-jobs-limit
branch
from
78d9ab7 to
7cb96fc
Compare
kdudka
previously approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Looks good. The updated csmock packages are now in epel9-testing: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-f4112db701
|
Waiting on update to konflux-test image: side note: it seems that in epel only the latest version of each package is kept, meaning older package versions are removed, which cause builds depending on older versions to fail (e.g. hermetic builds). Example: |
sfowl
force-pushed
the
shellcheck-jobs-limit
branch
from
5136269 to
bb808a1
Compare
- PSSECAUT-1196 - set sast-shell-check default CPU limit to 8 - set SC_JOBS equal to CPU limit (rounded up) based on cgroups v2 max - fix issue with IFS=, affecting word splitting (which impacted `read -r quota period < /sys/fs/cgroup/cpu.max`)
This version includes an update to csmock-shellcheck-plugin-core that uses the existing value of SC_JOBS in run-shellcheck.sh
sfowl
force-pushed
the
shellcheck-jobs-limit
branch
from
bb808a1 to
fb9c928
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
kdudka
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read -r quota period < /sys/fs/cgroup/cpu.max)Marked as draft for now, as it requires an updated version of the quay.io/konflux-ci/konflux-test image with a new epel9 release of csmock-plugins-shellcheck-core with this change.EDIT: konflux-test image has been updated, ready for merge