Skip to content

fix(KFLUXSPRT-3673): set timeouts for internal-request #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

theflockers
Copy link
Contributor

this PR adds the parameters --pipeline-timeout and --task-timeout in the internal-request command
line to control the timeouts of the internal
requests created by the add-fbc-contribution task

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Jun 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theflockers theflockers force-pushed the kfluxsprt-3673 branch 2 times, most recently from f4ce0e1 to 88ec654 Compare June 20, 2025 15:25
@theflockers
Copy link
Contributor Author

/ok-to-test

@theflockers theflockers force-pushed the kfluxsprt-3673 branch 3 times, most recently from 622507e to 2fe852d Compare July 4, 2025 09:43
@theflockers theflockers marked this pull request as ready for review July 4, 2025 09:50
@theflockers theflockers requested a review from a team as a code owner July 4, 2025 09:50
@theflockers
Copy link
Contributor Author

/retest

@theflockers theflockers force-pushed the kfluxsprt-3673 branch 3 times, most recently from 8009eed to 2d778c6 Compare July 7, 2025 14:27
Copy link
Contributor

@FilipNikolovski FilipNikolovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

this PR adds the parameters --pipeline-timeout and
--task-timeout in the internal-request command
line to control the timeouts of the internal
requests created by the add-fbc-contribution task

Signed-off-by: Leandro Mendes <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jul 8, 2025
@theflockers theflockers enabled auto-merge (squash) July 8, 2025 15:54
@openshift-ci openshift-ci bot added the lgtm label Jul 8, 2025
@theflockers theflockers merged commit f54195f into konflux-ci:development Jul 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants