feat(RELEASE-1716): new krw test for release-to-github #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
reviewed
Jun 25, 2025
scoheb
force-pushed
the
RELEASE-1716
branch
2 times, most recently
from
756d86d to
c9193b4
Compare
jinqi7
reviewed
Jun 26, 2025
scoheb
force-pushed
the
RELEASE-1716
branch
2 times, most recently
from
e579973 to
437938f
Compare
johnbieren
reviewed
Jun 26, 2025
johnbieren
reviewed
Jun 26, 2025
scoheb
force-pushed
the
RELEASE-1716
branch
2 times, most recently
from
2e52b28 to
d215d9b
Compare
jinqi7
previously approved these changes
Jun 27, 2025
scoheb
force-pushed
the
RELEASE-1716
branch
3 times, most recently
from
1c1c442 to
c657a5d
Compare
scoheb
force-pushed
the
RELEASE-1716
branch
2 times, most recently
from
45b3ea4 to
0424a4f
Compare
scoheb
force-pushed
the
RELEASE-1716
branch
2 times, most recently
from
89ba8ef to
d6c6409
Compare
|
LGTM. I only think it will be more simple to add an uuid for the checksum file in the Dockerfile, but it's also ok for me with the current way. |
jinqi7
approved these changes
Jul 8, 2025
|
New changes are detected. LGTM label has been removed. |
- new KRW test for release-to-github - includes verifying that the Release tag exists. Assisted-by: Cursor Signed-off-by: Scott Hebert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>