Skip to content

feat(CLDX-270): generate advisories for github pipeline #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

feat(CLDX-270): generate advisories for github pipeline #1129

wants to merge 1 commit into from
+675 −73

Conversation

swickersh
Copy link
Contributor

@swickersh swickersh commented Jun 26, 2025 •
edited
Loading

  • adds advisory creation tasks to release-to-github pipeline
  • adds conditional to create-advisory task to work with github data
  • adds steps to create unique release-notes for github to
    populate-release-notes task

Relevant Jira

CLDX-270

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2025

Hi @swickersh. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swickersh swickersh force-pushed the cldx-270 branch 3 times, most recently from 03f36f3 to 67b9884 Compare July 8, 2025 16:32
@swickersh swickersh changed the title Draft - release-to-github advisories feat(CLDX-270): generate advisories for github pipeline Jul 8, 2025
@swickersh
Copy link
Contributor Author

I am removing draft status now and ready for reviews.
I have a separate story for e2e tests to be updated and that might need to be merged before this. Planning to start working on that now.
This change still needs communicated to the one team that uses this pipeline, so please do not merge after reviews. Is there a do-not-merge label for this repo?
I'll leave a comment when I've updated documentation and talked to rhcs-terraform team. I can ask them to review here as well.

@swickersh swickersh marked this pull request as ready for review July 8, 2025 16:52
@swickersh swickersh requested a review from a team as a code owner July 8, 2025 16:52
@johnbieren
Copy link
Collaborator

I am removing draft status now and ready for reviews. I have a separate story for e2e tests to be updated and that might need to be merged before this. Planning to start working on that now. This change still needs communicated to the one team that uses this pipeline, so please do not merge after reviews. Is there a do-not-merge label for this repo? I'll leave a comment when I've updated documentation and talked to rhcs-terraform team. I can ask them to review here as well.

No, typically we use the draft status and still ask for review for that scenario

@johnbieren
Copy link
Collaborator

/ok-to-test

@swickersh
Copy link
Contributor Author

I am removing draft status now and ready for reviews. I have a separate story for e2e tests to be updated and that might need to be merged before this. Planning to start working on that now. This change still needs communicated to the one team that uses this pipeline, so please do not merge after reviews. Is there a do-not-merge label for this repo? I'll leave a comment when I've updated documentation and talked to rhcs-terraform team. I can ask them to review here as well.

No, typically we use the draft status and still ask for review for that scenario

ack, I'll move back to draft. thanks

@swickersh swickersh marked this pull request as draft July 10, 2025 18:45
johnbieren
johnbieren reviewed Jul 10, 2025
View reviewed changes
@swickersh
feat(CLDX-270): generate advisories for github pipeline
3973e93 
- adds advisory creation tasks to release-to-github pipeline
- adds conditional to create-advisory task to work with github data
- adds steps to create unique release-notes for github to
  populate-release-notes task

Signed-off-by: Scott Wickersham <[email protected]>
@johnbieren
Copy link
Collaborator

You have a unit test failure. I don't have any more changes to ask for with the current changes proposed though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swickersh @johnbieren @openshift-merge-robot