-
Notifications
You must be signed in to change notification settings - Fork 79
chore: update release-service-utils image to latest version #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
chore: update release-service-utils image to latest version #1143
Conversation
Skipping CI for Draft Pull Request. |
8ed9975
to
0ca3295
Compare
0ca3295
to
44d7298
Compare
@FilipNikolovski why now? Is this part of a Jira? we will do this soon enough anyway and I tried it out here (task tests failed when there were many different images in the tasks): #1110 |
Ah I missed that one, I can close this PR then if we already have one open for this. Also, it's part of https://issues.redhat.com/browse/RELEASE-1664, but it can certainly wait. |
I can close mine, no problem - it was just a test.
Ah, I see. Up until now our typical practice would be to update only the tasks that need the update. But I am fine with using this as an opportunity to update all for the first time. @johnbieren WDYT? |
Also, another note here, you're switching all of these references from tags to digests. We only use tags for references, I think in the future this might change, especially if we get mintMaker :) |
Ah you're right, should I use the tag here, or do we want to switch to using the digest from now on? |
I’d stick with tags for readability. Otherwise, we’d have to include each pinned digest with a comment on its tag so we can keep track. I believe Mintmaker handles pinning automatically. Maybe other people have views. |
Sounds good, let's stick with tags for now, I'll make the update. |
Signed-off-by: Filip Nikolovski <[email protected]>
44d7298
to
0253852
Compare
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I am fine with it. It will be nice to get to the point where all of our tasks and tests are using the latest image |
I know clicking on the 414 files changed tab is going to crash my chrome after about 5 mins, so I will wait for rebase to try taking a look 🙂 |
Describe your changes
Update the release-service-utils to the latest version.
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>