Skip to content

chore: update release-service-utils image to latest version #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

FilipNikolovski
Copy link
Contributor

Describe your changes

Update the release-service-utils to the latest version.

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Jun 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@FilipNikolovski FilipNikolovski force-pushed the update-utils-image-version branch from 8ed9975 to 0ca3295 Compare June 30, 2025 08:37
@FilipNikolovski FilipNikolovski marked this pull request as ready for review June 30, 2025 08:52
@FilipNikolovski FilipNikolovski requested a review from a team as a code owner June 30, 2025 08:52
@FilipNikolovski FilipNikolovski force-pushed the update-utils-image-version branch from 0ca3295 to 44d7298 Compare June 30, 2025 10:47
@mmalina
Copy link
Contributor

mmalina commented Jun 30, 2025

@FilipNikolovski why now? Is this part of a Jira? we will do this soon enough anyway and I tried it out here (task tests failed when there were many different images in the tasks): #1110

@FilipNikolovski
Copy link
Contributor Author

@FilipNikolovski why now? Is this part of a Jira? we will do this soon enough anyway and I tried it out here (task tests failed when there were many different images in the tasks): #1110

Ah I missed that one, I can close this PR then if we already have one open for this. Also, it's part of https://issues.redhat.com/browse/RELEASE-1664, but it can certainly wait.

@mmalina
Copy link
Contributor

mmalina commented Jun 30, 2025

@FilipNikolovski why now? Is this part of a Jira? we will do this soon enough anyway and I tried it out here (task tests failed when there were many different images in the tasks): #1110

Ah I missed that one, I can close this PR then if we already have one open for this.

I can close mine, no problem - it was just a test.

Also, it's part of https://issues.redhat.com/browse/RELEASE-1664, but it can certainly wait.

Ah, I see. Up until now our typical practice would be to update only the tasks that need the update. But I am fine with using this as an opportunity to update all for the first time. @johnbieren WDYT?

@seanconroy2021
Copy link
Member

Also, another note here, you're switching all of these references from tags to digests. We only use tags for references, I think in the future this might change, especially if we get mintMaker :)

@FilipNikolovski
Copy link
Contributor Author

Also, another note here, you're switching all of these references from tags to digests. We only use tags for references, I think in the future this might change, especially if we get mintMaker :)

Ah you're right, should I use the tag here, or do we want to switch to using the digest from now on?

@seanconroy2021
Copy link
Member

seanconroy2021 commented Jul 1, 2025

Ah you're right, should I use the tag here, or do we want to switch to using the digest from now on?

I’d stick with tags for readability. Otherwise, we’d have to include each pinned digest with a comment on its tag so we can keep track. I believe Mintmaker handles pinning automatically.

Maybe other people have views.

@FilipNikolovski
Copy link
Contributor Author

Ah you're right, should I use the tag here, or do we want to switch to using the digest from now on?

I’d stick with tags for readability. Otherwise, we’d have to include each pinned digest with a comment on its tag so we can keep track. I believe Mintmaker handles pinning automatically.

Maybe other people have views.

Sounds good, let's stick with tags for now, I'll make the update.

@FilipNikolovski
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@johnbieren
Copy link
Collaborator

@FilipNikolovski why now? Is this part of a Jira? we will do this soon enough anyway and I tried it out here (task tests failed when there were many different images in the tasks): #1110

Ah I missed that one, I can close this PR then if we already have one open for this.

I can close mine, no problem - it was just a test.

Also, it's part of https://issues.redhat.com/browse/RELEASE-1664, but it can certainly wait.

Ah, I see. Up until now our typical practice would be to update only the tasks that need the update. But I am fine with using this as an opportunity to update all for the first time. @johnbieren WDYT?

I am fine with it. It will be nice to get to the point where all of our tasks and tests are using the latest image

@johnbieren
Copy link
Collaborator

I know clicking on the 414 files changed tab is going to crash my chrome after about 5 mins, so I will wait for rebase to try taking a look 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants