-
Notifications
You must be signed in to change notification settings - Fork 84
fix: kubectl argument too long when updating release cr #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kubectl argument too long when updating release cr #1221
Conversation
266db4d
to
c80a391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from the lint errors.
c80a391
to
9179b08
Compare
This fails gitlint, yamllint, unit tests, and has a rebase conflict |
Converting to draft as I need to check to see whether #1214 resolves this same issue. |
9179b08
to
74859cd
Compare
This PR is ready for review again. #1214 duplicated much of the work for this PR, so now it is distilled down just to the status update issue. |
2cbab8d
to
a8b35eb
Compare
New changes are detected. LGTM label has been removed. |
I haven't seen that before |
bfbe1ab
to
0652b95
Compare
/retest |
When patching the Release with a lot of information, we are putting too much into the command line to be able to be processed. We can use a patch file instead of passing it all in the command line. Assisted-by: Cursor Signed-off-by: arewm <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
ce05deb
to
a43ffdc
Compare
@arewm: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:push-to-external-registry-e2e-test-go-jslpl Test results analysis🚨 Error occurred while running the E2E tests, list of failed Spec(s): ➡️ [ Click to view logsError when waiting for a release pipelinerun for release ex-registry-mbfe/snapshot-sample-ndyw-wtdgd to finish Expected success, but got an error: <*errors.errorString | 0xc000efc9e0>: Pipelinerun 'managed-m4f6c' didn't succeed Logs from failed container 'managed-m4f6c-verify-conforma/step-show-config': jq: error: Could not open file /tekton/home/report-json.json: No such file or directory { s: "Pipelinerun 'managed-m4f6c' didn't succeed\nLogs from failed container 'managed-m4f6c-verify-conforma/step-show-config': \njq: error: Could not open file /tekton/home/report-json.json: No such file or directory\n", } |
Describe your changes
Most of the development and CI has been done assuming smaller Snapshots. When releasing larger snapshots (i.e. 180 components), we start to encounter issues ranging from higher likelihood to hit timeouts, increased memory consumption, and long strings being processed.
This PR is focused on fixing an issue where
update-cr-status
could not process large snapshots, namely because we were passing too much information tokubectl
.Partially addresses: KONFLUX-8821 in conjunction with #1218, #1219, #1220
Assisted-by: Cursor
Signed-off-by: arewm [email protected]
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>
.github/scripts/readme_generator.sh
and verified the results using.github/scripts/check_readme.sh