fix(RELEASE-1701): return latest advisory URL when all components already released #1474
Conversation
happybhati
changed the title
happybhati
force-pushed
the
RELEASE-1701
branch
4 times, most recently
from
969cd53 to
c986d74
Compare
|
/retest |
happybhati
force-pushed
the
RELEASE-1701
branch
from
c986d74 to
f685e40
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
...managed/filter-already-released-advisory-images/filter-already-released-advisory-images.yaml
Outdated
Show resolved
Hide resolved
| - "$(tasks.run-file-updates.results.sourceDataArtifact)=$(params.dataDir)" | ||
| - "$(tasks.process-product-sbom.results.sourceDataArtifact)=$(params.dataDir)" | ||
| - "$(tasks.process-component-sbom.results.sourceDataArtifact)=$(params.dataDir)" | ||
| - "$(tasks.filter-already-released-advisory-images.results.sourceDataArtifact)=$(params.dataDir)" |
There was a problem hiding this comment.
did you make sure that it won't overwrite the advisory url with the empty string when the advisory did not already exist?
There was a problem hiding this comment.
Thanks for mentioning! fixed
There was a problem hiding this comment.
I wasn't really advocating for adding a new result, just to make sure that the empty string didn't overwrite the real one, but I'll leave implementation up to you
There was a problem hiding this comment.
Fixed the potential overwrite issue by making the filter task only create advisory data in the results file when skip_release=true
Pipeline behavior: When all components are already released (skip_release=true), the downstream tasks (including create-advisory and update-cr-status) are automatically skipped due to their when conditions. The latest advisory URL is exposed as a task result from the filter task for visibility in logs/UI.
There was a problem hiding this comment.
The ticket also talks about the task currently returning "just any" already released advisory instead of the latest. I don't see any changes here to address that
There was a problem hiding this comment.
oh yes so create advisory also needs to return the latest match advisory URL. And filter-already-released abisory task do the same.
Does it make sense?
There was a problem hiding this comment.
Acceptance criteria
- The latest advisory is returned as a new result to the user.
There was a problem hiding this comment.
Both tasks now sort advisories by modification time (newest first) and return the first matching advisory (which is the latest)
...lter-already-released-advisory-images-task/filter-already-released-advisory-images-task.yaml
Outdated
Show resolved
Hide resolved
...lter-already-released-advisory-images-task/filter-already-released-advisory-images-task.yaml
Outdated
Show resolved
Hide resolved
|
I am making some adjustments, putting it back in the draft quickly. I will ping once ready for review again. |
happybhati
force-pushed
the
RELEASE-1701
branch
2 times, most recently
from
5736055 to
1ae982a
Compare
|
/retest |
When all images in a snapshot are already released in advisories, the filter task now returns the URL of the latest matching advisory instead of no URL. This addresses user confusion during retries where they received older advisory URLs. - Add latest_advisory_url and latest_advisory_internal_url results - Write results file with advisory info for update-cr-status - Update pipeline to include filter task results - Add comprehensive tests for new functionality Signed-off-by: Happy Bhati <[email protected]>
happybhati
force-pushed
the
RELEASE-1701
branch
from
1ae982a to
6e9a5a2
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
3 participants
When all images in a snapshot are already released in advisories, the filter task now returns the URL of the latest matching advisory instead of no URL. This addresses user confusion during retries where they received older advisory URLs.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>.github/scripts/readme_generator.shand verified the results using.github/scripts/check_readme.sh