fix(RHELWF-13471): import draft builds with correct sidetags

[hluk]

Describe your changes

Avoid attaching "-draft" to sidetag names for draft builds.

Relevant Jira

RHELWF-13471

Checklist before requesting a review

• I have marked as draft or added do not merge label if there's a dependency PR
  • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
• My commit message includes Signed-off-by: My name <email>
• I read CONTRIBUTING.MD and commit formatting
• I have run the README.md generator script in .github/scripts/readme_generator.sh and verified the results using .github/scripts/check_readme.sh

[davidmogar]

This LGTM but I'd like to get @mmalina opinion on it.

[mmalina]

LGTM, but the tests fail now. Let me know if you need help with that.

[elenagerman]

/lgtm, please rebase

[mmalina]

@elenagerman FYI, /lgtm doesn't do anything in this repo. You need to use Github UI to approve. Also, there isn't really any need to rebase the PR, unless there are conflicts (which the UI would warn about).

[hluk]

/lgtm, please rebase

Rebased.

[hluk]

I fixed the failing test: Again problem with bash - we really need to migrate to Python - the bash code is not very maintainable.

[elenagerman]

correct me if I'm wrong, but it looks like there's a missing else clause

Suggested change

	if [[ "$draft" == "true" ]]; then
	is_sidetag=$(is_sidetag "$koji_target")
	if [[ "$is_sidetag" == "true" ]]; then
	koji_tag=${koji_target}
	elif [[ "$koji_target" != *-draft ]]; then
	koji_tag=${koji_target%-candidate}-draft
	fi
	else
	if [[ "$draft" == "true" ]]; then
	is_sidetag=$(is_sidetag "$koji_target")
	if [[ "$is_sidetag" == "true" ]]; then
	koji_tag=${koji_target}
	elif [[ "$koji_target" != *-draft ]]; then
	koji_tag=${koji_target%-candidate}-draft
	else
	koji_tag=${koji_target}
	fi
	else

[hluk]

Ah, you are right, thanks. I'm thinking about reverting it to the previous version, without the nested ifs.

[hluk]

Fixed.

[mmalina]

I fixed the failing test: Again problem with bash - we really need to migrate to Python - the bash code is not very maintainable.

FWIW, you can create a python script in the utils repo and use it in your task. That way you can have normal python unit tests.

[mmalina]

/ok-to-test

[elenagerman]

@elenagerman FYI, /lgtm doesn't do anything in this repo. You need to use Github UI to approve. Also, there isn't really any need to rebase the PR, unless there are conflicts (which the UI would warn about).

Thank you @mmalina ! it was just the sign that's all good, and I wait for rebase (+ all tests passe) to approve (if needed) :)

[hluk]

Is there any problem with CI again?