fix: modify dirs to build rpms out of signed kmods #1503
+706
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect, but WDYT about implementing 2-4 tests to verify related code changes? |
enriquebelarte
force-pushed
the
fix-rpm-signed-kos
branch
2 times, most recently
from
ffa842e to
d222862
Compare
happybhati
reviewed
Oct 13, 2025
Comment on lines
121
to
123
| # Copy signed kmods and envfile to working directory | ||
| cp "${SIGNED_KMODS_PATH}"/*.ko . | ||
| cp "${SIGNED_KMODS_PATH}/envfile" . |
There was a problem hiding this comment.
Code and test look solid, thanks for the fix.
Small Suggestions:
Before copying, should we consider checking if the envfile and any .ko files exist, to provide clearer error messages if they are missing?
When using cp "${SIGNED_KMODS_PATH}"/*.ko ., if there are no .ko files, cp will fail. You might want to handle this case gracefully? correct me if I am wrong because I am not the expert on OOT-kmods-rpms :)
There was a problem hiding this comment.
The checks were moved before the cp command to provide better context in case of failure.
Thanks @happybhati
enriquebelarte
force-pushed
the
fix-rpm-signed-kos
branch
from
d222862 to
14cb2bf
Compare
We were building rpms with the original unsigned kmods Signed-off-by: Enrique Belarte Luque <[email protected]>
enriquebelarte
force-pushed
the
fix-rpm-signed-kos
branch
from
14cb2bf to
7480127
Compare
elenagerman
approved these changes
Oct 13, 2025
happybhati
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were building rpms with the original unsigned kmods