Skip to content

feat(CLOUDDST-26262): create pyxis image for operator index images #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

emilyzheng
Copy link
Contributor

@emilyzheng emilyzheng commented May 27, 2025

Describe your changes

To make the catalog page of redhat/redhat-operator-index updated with index images released from Konflux, tasks are added to fbc-release to create pyxis image for index image. collect-index-images is created to generate the snapshotPath required by create-pyxis-image.

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

@emilyzheng emilyzheng requested a review from a team as a code owner May 27, 2025 10:25
Copy link

openshift-ci bot commented May 27, 2025

Hi @emilyzheng. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@emilyzheng emilyzheng force-pushed the fbc-create-pyxis-image branch 2 times, most recently from e270ddb to 049d443 Compare May 27, 2025 10:58
@johnbieren
Copy link
Collaborator

/ok-to-test

@jinqi7
Copy link
Collaborator

jinqi7 commented May 28, 2025

/retest

@emilyzheng emilyzheng force-pushed the fbc-create-pyxis-image branch 5 times, most recently from eee4901 to c67e240 Compare June 9, 2025 07:12
@jinqi7
Copy link
Collaborator

jinqi7 commented Jun 25, 2025

/ok-to-test

@jinqi7
Copy link
Collaborator

jinqi7 commented Jun 25, 2025

/retest

1 similar comment
@jinqi7
Copy link
Collaborator

jinqi7 commented Jun 25, 2025

/retest

@johnbieren johnbieren force-pushed the fbc-create-pyxis-image branch from 99ee0b6 to 254fd25 Compare June 25, 2025 12:33
@johnbieren
Copy link
Collaborator

/ok-to-test

mmalina added a commit to mmalina/release-service-catalog that referenced this pull request Jun 26, 2025
This was already added recently in the e2e repo,
but was missing here in the new integration test.

It's needed for these two new things:

* konflux-ci#808
* konflux-ci#981

Also, remove unsupported skipLayers param from collectors rpa.
skipLayers has been replaced by includeLayers and no layers
are included by default.
mmalina added a commit to mmalina/release-service-catalog that referenced this pull request Jun 26, 2025
This was already added recently in the e2e repo,
but was missing here in the new integration test.

It's needed for these two new things:

* konflux-ci#808
* konflux-ci#981

Also, remove unsupported skipLayers param from collectors rpa.
skipLayers has been replaced by includeLayers and no layers
are included by default.

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-catalog that referenced this pull request Jun 26, 2025
This was already added recently in the e2e repo,
but was missing here in the new integration test.

It's needed for these two new things:

* konflux-ci#808
* konflux-ci#981

Also, remove unsupported skipLayers param from collectors rpa.
skipLayers has been replaced by includeLayers and no layers
are included by default.

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-catalog that referenced this pull request Jun 26, 2025
This was already added recently in the e2e repo,
but was missing here in the new integration test.

It's needed for these two new things:

* konflux-ci#808
* konflux-ci#981

Also, remove unsupported skipLayers param from collectors rpa.
skipLayers has been replaced by includeLayers and no layers
are included by default.

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit that referenced this pull request Jun 26, 2025
This was already added recently in the e2e repo,
but was missing here in the new integration test.

It's needed for these two new things:

* #808
* #981

Also, remove unsupported skipLayers param from collectors rpa.
skipLayers has been replaced by includeLayers and no layers
are included by default.

Signed-off-by: Martin Malina <[email protected]>
@happybhati
Copy link
Contributor

/retest

@emilyzheng
Copy link
Contributor Author

Adding quay token to SA in production https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/7550 is merged. I'm confirming if it needs manual deployment or not.

@emilyzheng
Copy link
Contributor Author

Adding quay token to SA in production https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/7550 is merged. I'm confirming if it needs manual deployment or not.

Parthey confirmed the added secret exists in SA. @mmalina are we good to merge this?

@emilyzheng emilyzheng force-pushed the fbc-create-pyxis-image branch from 254fd25 to 0e32d76 Compare July 3, 2025 01:32
@jinqi7
Copy link
Collaborator

jinqi7 commented Jul 3, 2025

/ok-to-test

@mmalina
Copy link
Contributor

mmalina commented Jul 3, 2025

Adding quay token to SA in production https://gitlab.cee.redhat.com/releng/konflux-release-data/-/merge_requests/7550 is merged. I'm confirming if it needs manual deployment or not.

Parthey confirmed the added secret exists in SA. @mmalina are we good to merge this?

OK, thanks for confirming. Yes, I think we should be able to merge this.

mmalina
mmalina previously approved these changes Jul 3, 2025
@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2025
@mmalina
Copy link
Contributor

mmalina commented Jul 3, 2025

/ok-to-test

@jinqi7
Copy link
Collaborator

jinqi7 commented Jul 4, 2025

/retest

To make the catalog page of redhat/redhat-operator-index updated with
index images released from Konflux, tasks are added to fbc-release to
create pyxis image for index image. collect-index-images is created
to generate the snapshotPath required by create-pyxis-image.

Signed-off-by: Emily Zheng <[email protected]>
Copy link

openshift-ci bot commented Jul 4, 2025

New changes are detected. LGTM label has been removed.

@jinqi7
Copy link
Collaborator

jinqi7 commented Jul 4, 2025

/ok-to-test

@jinqi7
Copy link
Collaborator

jinqi7 commented Jul 7, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants