Fix kubelet proxy configuration race condition #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
changed the title
|
Specs and e2e pass, can't confirm if this fixes the |
jakolehm
reviewed
Jun 5, 2019
| @@ -15,7 +15,7 @@ class Host < Pharos::Configuration::Struct | |||
| attribute :private_address, Pharos::Types::Strict::String.optional.default(nil) | |||
| attribute :private_interface, Pharos::Types::Strict::String.optional.default(nil) | |||
| attribute :role, Pharos::Types::Strict::String | |||
| attribute :labels, Pharos::Types::Strict::Hash | |||
| attribute :labels, Pharos::Types::Strict::Hash.default(proc { {} }) | |||
There was a problem hiding this comment.
Is this the minimal fix? Other changes are just extra?
There was a problem hiding this comment.
My understanding is that setting node labels in def labels is the problem. The changes to initialize make the host set the node role labels and taints already upon initialization.
|
Looks like merge broke it. |
jakolehm
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix the race condition in
Configure kubelet proxyFirst round: alter the way initial node labels are set