Skip to content

kontena-stats addon #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 28, 2019
Merged

kontena-stats addon #988

merged 18 commits into from
May 28, 2019

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Jan 17, 2019 •
edited
Loading 

addons:
  kontena-stats:
    enabled: true
    node_selector: {}
    tolerations: []
    retention:
      size: 1GB
      time: 90d
    persistence:
      enabled: false
    alertmanagers: []

@jakolehm jakolehm added enhancement New feature or request pro labels Jan 17, 2019
@jakolehm jakolehm changed the title [WIP] kontena-stats addon kontena-stats addon Mar 25, 2019
@jakolehm jakolehm added this to the 2.4.0 milestone Mar 25, 2019
@jakolehm jakolehm requested a review from jnummelin March 25, 2019 06:40
@jakolehm
Copy link
Contributor Author

@jnummelin PTAL

jakolehm
jakolehm commented Mar 25, 2019
View reviewed changes
non-oss/pharos_pro/addons/kontena-stats/resources/10-node-exporter-ds.yml Outdated
- --path.procfs=/host/proc
- --path.sysfs=/host/sys
- --path.rootfs=/host/root
- --collector.filesystem.ignored-mount-points=^/(dev|proc|sys|var/lib/docker/.+)($|/)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ignore /var/lib/containers that CRI-O uses?

@jakolehm jakolehm mentioned this pull request Mar 25, 2019
Merged
@jakolehm jakolehm modified the milestones: 2.4.0, 2.5.0 May 11, 2019
@jakolehm jakolehm requested a review from nevalla May 27, 2019 06:09
@jakolehm
Copy link
Contributor Author

@jnummelin @nevalla PTAL

nevalla
nevalla reviewed May 27, 2019
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue(?) related to alertmanager, otherwise seems to work as expected

@jakolehm
Copy link
Contributor Author

@nevalla PTAL

@jakolehm jakolehm merged commit 6644da2 into master May 28, 2019
@jakolehm jakolehm deleted the feature/kontena-stats branch May 28, 2019 05:44
@jakolehm jakolehm mentioned this pull request May 29, 2019
Merged
@jakolehm jakolehm mentioned this pull request Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla left review comments

@jnummelin jnummelin jnummelin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @nevalla @jnummelin