-
Notifications
You must be signed in to change notification settings - Fork 21
🌱 Add step to publish to open-vsx #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hiteshwari Patel <[email protected]>
Signed-off-by: Hiteshwari Patel <[email protected]>
Signed-off-by: Hiteshwari Patel <[email protected]>
Signed-off-by: Hiteshwari Patel <[email protected]>
WalkthroughAdds an explicit npm install step ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (2)
.github/workflows/release.yml
(1 hunks)vscode/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build (macos)
- GitHub Check: Build (linux)
- GitHub Check: Build (windows)
🔇 Additional comments (1)
vscode/package.json (1)
451-452
: Keep package-lock in sync with these new devDependenciesAdding
@vscode/vsce
andovsx
requires updatingvscode/package-lock.json
; otherwise the newnpm ci
step will fail when it cannot resolve these packages. Please regenerate and commit the lockfile update so CI has the exact versions recorded.
150ffe8
to
07cef50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (2)
.github/workflows/release.yml
(1 hunks)vscode/package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build (windows)
- GitHub Check: Build (linux)
- GitHub Check: Build (macos)
"@vscode/vsce": "latest", | ||
"ovsx": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin vsce/ovsx versions for deterministic releases.
Relying on the floating "latest"
tag means every npm ci
can pull a different CLI, so the release workflow may suddenly break or change behavior without any PR. Please lock both packages to known-good versions (e.g., ^x.y.z
) and update them intentionally via PR when needed. This keeps the publishing pipeline reproducible and auditable.
🤖 Prompt for AI Agents
In vscode/package.json around lines 451-452 the dev dependencies use floating
"latest" for @vscode/vsce and ovsx which makes releases non-deterministic;
change both entries to pinned semver ranges (e.g., ^x.y.z) referencing
known-good versions, run npm ci / install to refresh and commit the updated
lockfile (package-lock.json or yarn.lock), and open a follow-up PR when
upgrading those pinned versions in future.
Signed-off-by: hhpatel14 <[email protected]>
07cef50
to
24bce4c
Compare
Signed-off-by: Hiteshwari Patel <[email protected]>
Add a step to publish the extension to the Open VSX registry.
Backport this change to the
release-8.0
branch and rerun the release workflow to catch up on publishing to the Open VSX registry. Since the v8.0.0 already published to maketplace, the step skips gracefully, logs “already published”, and proceed to the next stepCI kept using deprecated [email protected] because no local version existed. The deprecated vsce CLI lacked flag
--changelog-path
and stuck at v2.15.0.@vscode/vsce
newer, well maintained and works with Node 20+.Summary by CodeRabbit
Chores
Build