Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaking adonis settings - upgrading node, removing mysql 5.7 all over #476

Merged
merged 1 commit into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions presets/adonis/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ create:
- name: Creating new Adonis Application
actions:
- scripts:
- docker pull -q kooldev/node:16
- kool docker kooldev/node:16 npx -y @adonisjs/cli new $CREATE_DIRECTORY
- kool docker kooldev/node:16 npm --prefix=$CREATE_DIRECTORY i @adonisjs/cli
- docker pull -q kooldev/node:18
- kool docker kooldev/node:18 npx -y @adonisjs/cli new $CREATE_DIRECTORY
- kool docker kooldev/node:18 npm --prefix=$CREATE_DIRECTORY i @adonisjs/cli

# Preset defines the workflow for installing this preset in the current working directory
preset:
Expand Down
3 changes: 0 additions & 3 deletions recipes/pick-db.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ actions:
- name: 'MySQL 8.0'
actions:
- recipe: mysql-8
- name: 'MySQL 5.7'
actions:
- recipe: mysql-5.7
- name: 'MariaDB 10.5'
actions:
- recipe: maria-10.5
Expand Down
4 changes: 2 additions & 2 deletions templates/app/node-adonis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
services:
app:
image: kooldev/node:16-adonis
command: ["adonis", "serve", "--dev"]
image: kooldev/node:18
command: ["npx", "adonis", "serve", "--dev"]
ports:
- "${KOOL_APP_PORT:-3333}:3333"
environment:
Expand Down
2 changes: 1 addition & 1 deletion templates/scripts/npm-adonis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ scripts:
npx: kool exec app npx

setup:
- kool docker kooldev/node:16 npm install
- kool docker kooldev/node:18 npm install
- kool start
2 changes: 1 addition & 1 deletion templates/scripts/yarn-adonis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ scripts:
yarn: kool exec app yarn

setup:
- kool docker kooldev/node:16 yarn install
- kool docker kooldev/node:18 yarn install
- kool start
Loading