Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint + fix regression on cloud config legacy file #504

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

fabriciojs
Copy link
Member

Issue -
🪲 Bug Fix Yes

Description

  • Fixes regression on legacy kool.deploy.yml file name fallback.
  • Fixes linting complaints.

@github-actions github-actions bot added release-drafter:fixed Release drafter: Fixed release-drafter:patch Release drafter: Patch labels Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (99eb85e) 70.01% compared to head (cfee540) 69.95%.

Files Patch % Lines
services/cloud/api/deploy_create.go 0.00% 1 Missing ⚠️
services/cloud/api/endpoint.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   70.01%   69.95%   -0.07%     
==========================================
  Files          77       77              
  Lines        3032     3032              
==========================================
- Hits         2123     2121       -2     
- Misses        844      847       +3     
+ Partials       65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit b4f5ef7 into main Feb 16, 2024
8 of 10 checks passed
@fabriciojs fabriciojs deleted the fix-lint-fallback branch February 16, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:fixed Release drafter: Fixed release-drafter:patch Release drafter: Patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant