DEVEXP-206: Now supporting auth via a basic header #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
reviewed
Feb 23, 2023
|
Closing this PR because it's not quite what we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that setting "data.filtersApplied.all = true", after the data has been retrieved from MarkLogic, prevents the filtering from happening (which prevents the null values from being ordered incorrectly).
However, setting that value all the time causes quite a few tests to fail. Additionally, it's conceivable that it would change current behavior that users don't want changed.
So, I propose a new query param, "skipFiltering". When that param is set to true, then data.filtersApplied.all is set to true, and the filtering step is skipped and the null values are sorted as expected.
Thoughts?