Fix Dockerfile #1180
Open
Fix Dockerfile #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Closes koopjs#1179 - Upgrades to current Node LTS (v22) - Uses "slim" Node image for smaller build (appears to work OK but haven't tested rigorously) - Runs `npm run demo` to be consistent with demo instructions in README
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Dockerfile, which was not pulling the monorepo packages into the container. It also updates the README adding Docker instructions for the demo, as well as a few a few typo tweaks.
I hope this is helpful — thank you Koop team for all the hard work you put into this project! 👋