Fix & enable HW rotation on notched devices on P+ (#288)

By updating the current handling to be rotation-aware.

app/src/main/java/org/koreader/launcher/MainActivity.kt

@@ -318,13 +318,24 @@ class MainActivity : NativeActivity(), JNILuaInterface,
         return ScreenUtils.getScreenAvailableHeight(this)
     }
 
+    override fun getScreenAvailableWidth(): Int {
+        return ScreenUtils.getScreenAvailableWidth(this)
+    }
+
     override fun getScreenBrightness(): Int {
         return device.getScreenBrightness(this)
     }
 
     override fun getScreenHeight(): Int {
         return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
-            ScreenUtils.getScreenHeight(this) - topInsetHeight
+            // We need to handle the notch in Portrait
+            // NOTE: getScreenAvailableHeight does it automatically, but it also excludes the nav bar, when there's one :/
+            if (device.getScreenOrientation(this).and(1) == 0) {
+                // getScreenOrientation returns LinuxFB rotation constants, Portrait rotations are always even
+                ScreenUtils.getScreenHeight(this) - topInsetHeight
+            } else {
+                ScreenUtils.getScreenHeight(this)
+            }
         } else {
             ScreenUtils.getScreenHeight(this)
         }
@@ -355,7 +366,18 @@ class MainActivity : NativeActivity(), JNILuaInterface,
     }
 
     override fun getScreenWidth(): Int {
-        return ScreenUtils.getScreenWidth(this)
+        return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
+            // We need to handle the notch in Landscape
+            // NOTE: getScreenAvailableWidth does it automatically, but it also excludes the nav bar, when there's one :/
+            if (device.getScreenOrientation(this).and(1) == 1) {
+                // getScreenOrientation returns LinuxFB rotation constants, Landscape rotations are always odd
+                ScreenUtils.getScreenWidth(this) - topInsetHeight
+            } else {
+                ScreenUtils.getScreenWidth(this)
+            }
+        } else {
+            ScreenUtils.getScreenWidth(this)
+        }
     }
 
     override fun getStatusBarHeight(): Int {
@@ -377,8 +399,7 @@ class MainActivity : NativeActivity(), JNILuaInterface,
     override fun hasNativeRotation(): Boolean {
         return if (device.platform == "android") {
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
-                // FIXME: hw rotation is disabled in devices with a Notch.
-                !((topInsetHeight > 0) || (device.bugRotation))
+                !(device.bugRotation)
             } else false
         } else false
     }

app/src/main/java/org/koreader/launcher/interfaces/JNILuaInterface.kt

@@ -26,6 +26,7 @@ interface JNILuaInterface {
     fun getPlatformName(): String
     fun getProduct(): String
     fun getScreenAvailableHeight(): Int
+    fun getScreenAvailableWidth(): Int
     fun getScreenBrightness(): Int
     fun getScreenHeight(): Int
     fun getScreenMaxBrightness(): Int

app/src/main/java/org/koreader/launcher/utils/ScreenUtils.kt

@@ -13,6 +13,10 @@ import java.util.concurrent.CountDownLatch
 object ScreenUtils {
     private const val TAG = "ScreenUtils"
 
+    fun getScreenAvailableWidth(activity: Activity): Int {
+        return getScreenSizeWithConstraints(activity).x
+    }
+
     fun getScreenAvailableHeight(activity: Activity): Int {
         return getScreenSizeWithConstraints(activity).y
     }

assets/android.lua

@@ -1761,6 +1761,16 @@ local function run(android_app_state)
         end)
     end
 
+    android.getScreenAvailableWidth = function()
+        return JNI:context(android.app.activity.vm, function(jni)
+            return jni:callIntMethod(
+                android.app.activity.clazz,
+                "getScreenAvailableWidth",
+                "()I"
+            )
+        end)
+    end
+
     android.getScreenAvailableHeight = function()
         return JNI:context(android.app.activity.vm, function(jni)
             return jni:callIntMethod(