Add encode_raw_plane_10_with_params.
#101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
requested changes
May 11, 2025
ravif/src/av1encoder.rs
Outdated
| @@ -344,7 +344,9 @@ impl Encoder { | |||
| &self, width: usize, height: usize, planes: impl IntoIterator<Item = [u8; 3]> + Send, alpha: Option<impl IntoIterator<Item = u8> + Send>, | |||
| color_pixel_range: PixelRange, matrix_coefficients: MatrixCoefficients, | |||
| ) -> Result<EncodedImage, Error> { | |||
| self.encode_raw_planes_internal(width, height, planes, alpha, color_pixel_range, matrix_coefficients, 8) | |||
| const TRANSFER_CHARACTERISTICS: TransferCharacteristics = TransferCharacteristics::SRGB; | |||
There was a problem hiding this comment.
The constants are not needed. You can use the values directly.
There was a problem hiding this comment.
Should I use the Resolve conversation the button ?
|
Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds
encode_raw_plane_10_with_paramstorav1f::av1encoder::Encoder, which allows encoding with color spaces besides sRGB.