Skip to content
This repository was archived by the owner on Jan 11, 2022. It is now read-only.

Translated sites added #6

Merged
merged 3 commits into from
Jan 14, 2014
Merged

Translated sites added #6

merged 3 commits into from
Jan 14, 2014

Conversation

rkrucker
Copy link
Contributor

@rkrucker rkrucker commented Dec 6, 2013

Sites translated hardcoded after stefans requests

@metaodi
Copy link
Member

metaodi commented Dec 6, 2013

I think the English version should be linked somewhere, not just be available as files => We need some kind of language switcher. And related: all English pages should link to the other English pages (e.g. developers_en.html should link to index_en.html not index.html).

@rkrucker
Copy link
Contributor Author

rkrucker commented Dec 6, 2013

will do so
Am 06.12.2013 13:41, schrieb Stefan Oderbolz:

I think the English version should be linked somewhere, not just be
available as files => We need some kind of language switcher. And
related: all English pages should link to the other English pages
(e.g. |developers_en.html| should link to |index_en.html| not
|index.html|).


Reply to this email directly or view it on GitHub
#6 (comment).

@rkrucker
Copy link
Contributor Author

rkrucker commented Dec 9, 2013

Morning
I got a quick question regarding the translation
Would you prefer an automatic redirection based on the browsers settings
or would you like some kind of field where the user can choose which
language should be displayed?
Am 06.12.2013 13:41, schrieb Stefan Oderbolz:

I think the English version should be linked somewhere, not just be
available as files => We need some kind of language switcher. And
related: all English pages should link to the other English pages
(e.g. |developers_en.html| should link to |index_en.html| not
|index.html|).


Reply to this email directly or view it on GitHub
#6 (comment).

Single files and button for switch added
@metaodi
Copy link
Member

metaodi commented Dec 10, 2013

@rkrucker we use the automatic detection already in Kort, so this would be perfect. If the guess is wrong, the user should be allowed to change the language himself.

@rkrucker
Copy link
Contributor Author

Are the changes made in the last commit(9.12.13) okay? I changed the doctype and added a little button to the topnavigation which takes you to the german/english version of the site you are looking at.
Additionally, Stefan asked me to ask you if you can grant me access to uservoice, transifex and maybe additional parts. kind regards rafael

@metaodi
Copy link
Member

metaodi commented Dec 10, 2013

Thank you very much for your pull request 👍 , I'll have a closer look at it tonight and give you feedback.

@metaodi
Copy link
Member

metaodi commented Dec 10, 2013

I quickly checked out your changes locally. Currently the browsing of the page is strange: if I choose to browse the English page, I want the navigation to point to all the English pages, this is currently not the case. This is what I meant with "all English pages should link to the other English pages (e.g. developers_en.html should link to index_en.html not index.html)".

Do you know what I mean?

@rkrucker
Copy link
Contributor Author

ah off course sorry, thats logical. I got stefans old instructions mixed
up in it, sorry.
I will make another commit today sometime before 7, (hopefully)
including the final pages
Am 10.12.2013 15:30, schrieb Stefan Oderbolz:

I quickly checked out your changes locally. Currently the browsing of
the page is strange: if I choose to browse the English page, I want
the navigation to point to all the English pages, this is currently
not the case. This is what I meant with "all English pages should link
to the other English pages (e.g. |developers_en.html| should link to
|index_en.html| not |index.html|)".

Do you know what I mean?


Reply to this email directly or view it on GitHub
#6 (comment).

all pages now should link the way you want them to, language button
alsways takes you to the other 'languaged' page you're looking at
metaodi added a commit that referenced this pull request Jan 14, 2014
@metaodi metaodi merged commit 9a86df0 into kort:master Jan 14, 2014
@metaodi
Copy link
Member

metaodi commented Jan 14, 2014

Thanks a lot for your efforts! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants