Skip to content

cinema - JS version #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

krylenger
Copy link
Collaborator

Please review my homework.

demo
codebase

Thanks in advance!

Copy link

@A-Ostrovnyy A-Ostrovnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Add some message or alert on submit. It helps users to understand current order state.

<h3 class="choose-section__title">Please double check</h3>
<div class="chosen-tickets__tickets-container chosen-tickets__tickets-container--modal" id="chosen-tickets__tickets-container--modal">
</div>
<a class="checkout-seats__checkout-button" id="checkout-seats__checkout-button--modal" type="submit">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit button not working. Please fix it
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed this.
Now it renders the success message, closes modal window after a short delay and resets the initial application.
Could you please check briefly the structure of my app and tell is it proper structured or maybe it should be done in other (more efficient) way.
Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants