Return correct output shape for MultiHeadAttention #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to `MultiHeadSelfAttention`, `MultiHeadAttention` has two inputs but only one input. The current implementation does not override `compute_output_shape`, which by default returns the input shapes unmodified. Instead, only the input shape of the decoder must be returned. Otherwise, this results in errors during model construction if the sequence length of the encoder and decoder differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to
MultiHeadSelfAttention,MultiHeadAttentionhas two inputs but only one input. The current implementation does not overridecompute_output_shape, which by default returns the input shapes unmodified. Instead, only the input shape of the decoder must be returned.Otherwise, this results in errors during model construction if the sequence length of the encoder and decoder differ.