Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a writer panic #31

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix a writer panic #31

merged 1 commit into from
Jun 28, 2024

Conversation

emilien-puget
Copy link
Contributor

fix a writer panic when the close function of the writer is called when no write has been done by initialising the writer with a noop span

@emilien-puget
fix a writer panic
4b6a610 
fix a writer panic when the close function of the writer is called when no write has been done
@emilien-puget
Copy link
Contributor Author

to be noted that the CI is broken

@ndreno
Copy link

ndreno commented Jun 27, 2024

Can we have a review of this by any chance fellas?

dhontecillas
dhontecillas approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@dhontecillas dhontecillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you very much for your contribution, and apologies for not being able to review it sooner.

@dhontecillas dhontecillas merged commit 18271f3 into krakend:main Jun 28, 2024
3 checks passed
@ndreno
Copy link

ndreno commented Jul 3, 2024

hey guys, there is the little sister here also #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhontecillas dhontecillas dhontecillas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilien-puget @ndreno @dhontecillas