Abstract the data path #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example you presented at ClojureX, knowledge of the core.async channel and the location of the counter's state leaked into the messages and view.
I've refactored this example to remove that coupling.
handle-with!
is a piece of generic machinery that uses anfmap
function and aview
function to wire up a component to where to find its state in the overall model. This could easily be pushed into Petrol's core, and possibly replacesend!
.You could easily write helpers that would construct
fmap
andview
from a path, though it's not necessary that they use a path at all - you might want to e.g. use a model containing seconds with a component that expects minutes.This may or may not match your plans for Petrol, but I thought it would be fun to use lens functions to make the wiring up simpler.