test: improve test assertions and remove 'vitest/expect-expect', 'vitest/valid-title' from ESLint warn rules (toss#1531)

Author: sukvvon

eslint.config.mjs

@@ -54,10 +54,8 @@ export default defineConfig(
     rules: {
       ...vitest.configs.recommended.rules,
       'vitest/no-commented-out-tests': 'warn',
-      'vitest/expect-expect': 'warn',
       'vitest/valid-expect': 'warn',
       'vitest/no-identical-title': 'warn',
-      'vitest/valid-title': 'warn',
     },
   },
   prettier,

src/compat/array/some.spec.ts

@@ -37,7 +37,7 @@ describe('some', () => {
         count++;
         return value;
       })
-    );
+    ).toBe(true);
 
     expect(count).toBe(2);
   });

src/compat/function/attempt.spec.ts

@@ -66,7 +66,7 @@ describe('attempt', () => {
     const actual = attempt(() => {
       throw new CustomError('x');
     });
-    expect(actual instanceof CustomError);
+    expect(actual instanceof CustomError).toBe(true);
   });
 
   it('should match the type of lodash', () => {

src/compat/function/bind.spec.ts

@@ -37,19 +37,19 @@ describe('bind', () => {
     const bound = bind(fn, null);
     const actual = bound('a');
 
-    expect(actual[0] === null);
+    expect(actual[0]).toBe(null);
     expect(actual[1]).toBe('a');
 
     const bound2 = bind(fn, undefined);
     const actual2 = bound2('b');
 
-    expect(actual2[0] === undefined);
+    expect(actual2[0]).toBe(undefined);
     expect(actual2[1]).toBe('b');
 
     const bound3 = (bind as any)(fn);
     const actual3 = bound3('b');
 
-    expect(actual3[0] === undefined);
+    expect(actual3[0]).toBe(undefined);
     expect(actual3[1]).toBe('b');
   });
 
@@ -100,7 +100,7 @@ describe('bind', () => {
 
     expect(bound().a).toBe(1);
     expect(newBound.a).toBe(undefined);
-    expect(newBound instanceof Foo);
+    expect(newBound instanceof Foo).toBe(true);
   });
 
   it('should handle a number of arguments when called with the `new` operator', () => {
@@ -135,7 +135,7 @@ describe('bind', () => {
     const bound = (bind as any)(Foo) as any;
     const object = {};
 
-    expect(new bound() instanceof Foo);
+    expect(new bound() instanceof Foo).toBe(true);
     expect(new bound(true)).toBe(object);
   });
 

src/compat/function/curry.spec.ts

@@ -90,7 +90,7 @@ describe('curry', () => {
     const object = {};
 
     // @ts-expect-error - curried is a constructor
-    expect(new curried(false) instanceof Foo);
+    expect(new curried(false) instanceof Foo).toBe(true);
 
     // @ts-expect-error - curried is a constructor
     expect(new curried(true)).toBe(object);

src/compat/function/curryRight.spec.ts

@@ -88,7 +88,7 @@ describe('curryRight', () => {
     const object = {};
 
     // @ts-expect-error - curried is a constructor
-    expect(new curried(false) instanceof Foo);
+    expect(new curried(false) instanceof Foo).toBe(true);
 
     // @ts-expect-error - curried is a constructor
     expect(new curried(true)).toBe(object);

src/compat/function/debounce.spec.ts

@@ -439,8 +439,7 @@ describe('debounce', () => {
   const methodName = 'debounce';
 
   it(`\`_.${methodName}\` should not error for non-object \`options\` values`, () => {
-    func(noop, 32, 1 as any);
-    expect(true);
+    expect(() => func(noop, 32, 1 as any)).not.toThrow();
   });
 
   it(`\`_.${methodName}\` should use a default \`wait\` of \`0\``, async () => {

src/compat/function/defer.spec.ts

@@ -31,7 +31,7 @@ describe('defer', () => {
     clearTimeout(timerId);
 
     setTimeout(() => {
-      expect(pass);
+      expect(pass).toBe(true);
       done();
     }, 32);
   });

src/compat/function/throttle.spec.ts

@@ -211,8 +211,7 @@ describe('throttle', () => {
   const methodName = 'throttle';
 
   it(`\`_.${methodName}\` should not error for non-object \`options\` values`, () => {
-    func(noop, 32, 1 as any);
-    expect(true);
+    expect(() => func(noop, 32, 1 as any)).not.toThrow();
   });
 
   it(`\`_.${methodName}\` should use a default \`wait\` of \`0\``, async () => {

src/compat/math/random.spec.ts

@@ -56,9 +56,9 @@ describe('random', () => {
         const result = random(min, max);
         return result >= min && result <= max;
       })
-    ).toBeTruthy();
+    ).toBe(true);
 
-    expect(array.some(() => random(Number.MAX_SAFE_INTEGER)));
+    expect(array.some(() => random(Number.MAX_SAFE_INTEGER))).toBe(true);
   });
 
   it('should coerce arguments to finite numbers', () => {