Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extreme_ers_ssh.py #3258

Closed
wants to merge 7 commits into from
Closed

Conversation

shivaraj-arch
Copy link
Contributor

Few Avaya ERS devices after SSH-login the Ctrl-Y turns to blank screen giving no pattern to search; prompt appears after Enter/Return key press ( tested ). With others this is just a Return key press and is safe.

Target Error: ReadTimeout::
Pattern not detected: '(?:sername|ssword|Ctrl-Y|(?m:[>#]\s*$))' in output.

Few Avaya ERS devices after SSH-login the Ctrl-Y turns to blank screen giving no pattern to search; prompt appears after Enter/Return key press ( tested ). With others this is just a Return key press and is safe.
Copy link
Contributor Author

@shivaraj-arch shivaraj-arch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require approval from maintainer

@shivaraj-arch
Copy link
Contributor Author

shivaraj-arch commented Oct 20, 2023

Netmiko

image

@ktbyers
Copy link
Owner

ktbyers commented Oct 20, 2023

@shivaraj-arch Can you show me what the SSH login looks like on these Avaya ERS devices?

I.E. copy-and-paste the CLI interaction into this Github issue.

flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Test with pytest
run: |
pytest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this (i.e. this change shouldn't be included in the PR).

Copy link
Owner

@ktbyers ktbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the GitHub actions file, that shouldn't be included in this PR.

@shivaraj-arch
Copy link
Contributor Author

@shivaraj-arch Can you show me what the SSH login looks like on these Avaya ERS devices?

I.E. copy-and-paste the CLI interaction into this Github issue.

@ktbyers sorry do not have access to it now, just saw this still lying and hence tried running workflow. Have tested it thoroughly then. It won't affect existing functionality, so no harm in adopting changes.

@shivaraj-arch
Copy link
Contributor Author

You should remove the GitHub actions file, that shouldn't be included in this PR.

Done.

@ktbyers
Copy link
Owner

ktbyers commented Oct 23, 2023

Superseded by:

#3324

To fix merge/out-of-date issues.

@ktbyers ktbyers closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants