-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extreme_ers_ssh.py #3258
Conversation
Few Avaya ERS devices after SSH-login the Ctrl-Y turns to blank screen giving no pattern to search; prompt appears after Enter/Return key press ( tested ). With others this is just a Return key press and is safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
require approval from maintainer
pycodestyle fixes
pycodestyle PEP8 fixes
PEP8 pycodestyle fix
@shivaraj-arch Can you show me what the SSH login looks like on these Avaya ERS devices? I.E. copy-and-paste the CLI interaction into this Github issue. |
.github/workflows/python-app.yml
Outdated
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
- name: Test with pytest | ||
run: | | ||
pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove this (i.e. this change shouldn't be included in the PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove the GitHub actions file, that shouldn't be included in this PR.
@ktbyers sorry do not have access to it now, just saw this still lying and hence tried running workflow. Have tested it thoroughly then. It won't affect existing functionality, so no harm in adopting changes. |
Done. |
Superseded by: To fix merge/out-of-date issues. |
Few Avaya ERS devices after SSH-login the Ctrl-Y turns to blank screen giving no pattern to search; prompt appears after Enter/Return key press ( tested ). With others this is just a Return key press and is safe.
Target Error: ReadTimeout::
Pattern not detected: '(?:sername|ssword|Ctrl-Y|(?m:[>#]\s*$))' in output.