Improve H3C/Comware check_config_mode #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to Cisco switches, H3C switches are too slow in executing commands because the value of the pattern is not set in the check_config_mode function. This function is called twice in both the config_mode and exit_config_mode, each time using read_channel_timing instead of read_until_pattern, which greatly extends the duration. This commit set default pattern of hp_comware to save time when checking the config mode.
|
@LeisureZhao FYI, fixed linting issue and removed the one pipe character here. |
|
@LeisureZhao Let me know if you run into any issues with this fix. I am going to go ahead and merge it into |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.