Add support to connect to HPE 1920 and 1950 OfficeConnect switches #3712
Conversation
HPE 1920 and 1950 switches has standard Comware5 / Comware7 CLI but it needs to be enabled with special command sent to the CLI. This patch add new hpe_officeconnect_model argument to HPComwareBase class. When this argument is populated with hpe1920 or hpe1950 string value, it send magic command immediately after establishing connection with switch and therefore these switches can be handled as standard Comware switches.
|
I can confirm that this is a special case those switches 👍 |
|
In this case instead of adding some argument to the credentials i would suggest creating a new device type or issue the command version on startup and based on that decide. If you go for the second option I can help you creating the template in NTC-Templates |
|
@evilmonkey19 issuing display version command was my first attempt to keep it simple without configuration. But problem is that even display version is not possible without enabling CLI :-/ In basic version there were some commands from which output is possible to determine what type switch is. But I've ended on that problem that these commands has long output which not fit on one screen (----more---- placer is returned to CLI). Command which disable paging is also available only after enabling full CLI. And even pipe (something like "| include 1920") is also available only with full CLI. So I didn't find the way how to detect switch model before enabling full CLI with something which not lead to terminal paging issue :-/ (If you have some idea, I can test it, i have bunch of both types of these switches). |
|
Then the best solution is to create a separated device_type for these type of switches and there is no way to detect them beforehand. |
…tches" This reverts commit 4418d18.
HPE 1920 and 1950 switches has standard Comware5 / Comware7 CLI but it needs to be enabled with special command sent to the CLI. This patch add new device communication classes based on current HPComwareBase class. These drivers during session initializations send special commands to enable full CLI and therefore after this initialization is possible to work with them like with regular Comware switches. For using these drivers were added 2 new device types: hp_comware1920 and hp_comware1950.
|
OK, I've reverted previous commit and I've added 2 new device types - one for 1920 series, second for 1950 series. |
|
Awesome! IMHO, It does look much cleaner not the codebase but also the usability for the user. 😃 |
2 participants
HPE 1920 and 1950 switches has standard Comware5 / Comware7 CLI but it needs to be enabled with special command sent to the CLI. This patch add new hpe_officeconnect_model argument to HPComwareBase class. When this argument is populated with hpe1920 or hpe1950 string value, it send magic command immediately after establishing connection with switch and therefore these switches can be handled as standard Comware switches.