Fix typing hints for timeouts: change from int to float #3720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI fails when type-checking keepalive: I believe this is a mistake in typeshed, because keepalive can definitely be a float (it is compared to I just opened python/typeshed#14596 to fix this in typeshed. |
Checking both Paramiko and Telnetlib, all those parameters are actually float. Only self.timeout seems to be used as an int in Netmiko itself, so it's left unchanged. The keepalive parameters was wrongly typed as an integer in typeshed, this has been fixed in python/typeshed#14596
jonglezb
force-pushed
the
fix_typing_hints
branch
from
c740564 to
58a6b08
Compare
|
With the new release 4.0.0.20250821 of types-paramiko, everything is green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking both Paramiko and Telnetlib, all those parameters are actually float.
Only self.timeout seems to be used as an int in Netmiko itself, so it's left unchanged.