Skip to content

Lint CI on commit and PR#4

Merged
MaximilianMeiler merged 3 commits intomainfrom
lint
Feb 2, 2024
Merged

Lint CI on commit and PR#4
MaximilianMeiler merged 3 commits intomainfrom
lint

Conversation

@kthchew
Copy link
Owner

@kthchew kthchew commented Feb 1, 2024

uses github actions CI

packaging has also changed - package.json is now in the root and contains dependencies, commands for both frontend and backend

please check that code changes don't break frontend/backend

Also modify code to pass linter
@jasonlin15
Copy link
Collaborator

Nice

S-Christensen
S-Christensen previously approved these changes Feb 2, 2024
Copy link
Collaborator

@S-Christensen S-Christensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i guess

@MaximilianMeiler
Copy link
Collaborator

WAIT. We need separate dependencies to make deploying simpler

@kthchew kthchew marked this pull request as draft February 2, 2024 18:44
@kthchew kthchew marked this pull request as ready for review February 2, 2024 19:20
@MaximilianMeiler MaximilianMeiler merged commit fceb31d into main Feb 2, 2024
@kthchew kthchew deleted the lint branch February 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants