Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint CI on commit and PR #4

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Lint CI on commit and PR #4

merged 3 commits into from
Feb 2, 2024

Conversation

kthchew
Copy link
Owner

@kthchew kthchew commented Feb 1, 2024

uses github actions CI

packaging has also changed - package.json is now in the root and contains dependencies, commands for both frontend and backend

please check that code changes don't break frontend/backend

Also modify code to pass linter
@jasonlin15
Copy link
Collaborator

Nice

MonsieurMantis
MonsieurMantis previously approved these changes Feb 2, 2024
Copy link
Collaborator

@MonsieurMantis MonsieurMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i guess

@MaximilianMeiler
Copy link
Collaborator

WAIT. We need separate dependencies to make deploying simpler

@MaximilianMeiler MaximilianMeiler merged commit fceb31d into main Feb 2, 2024
5 checks passed
@kthchew kthchew deleted the lint branch February 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants