-
Notifications
You must be signed in to change notification settings - Fork 331
Update Ktor version to 3.2.2 #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Walkthrough
This change updates the Ktor framework and plugin version from 3.2.1 to 3.2.2 across multiple Gradle, Maven, and configuration files. It also adds a new release entry for 3.2.2 in the documentation and adjusts release note formatting and links for previous versions. No code or public API changes are introduced.
## Changes
| Files/Groups | Change Summary |
|-------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|
| codeSnippets/gradle.properties,<br>codeSnippets/snippets/migrating-express-ktor/gradle.properties | Updated Ktor version from 3.2.1 to 3.2.2 |
| codeSnippets/snippets/**/build.gradle.kts | Updated `io.ktor.plugin` Gradle plugin version from 3.2.1 to 3.2.2 in multiple build scripts |
| codeSnippets/snippets/**/gradle/libs.versions.toml | Updated Ktor library version from 3.2.1 to 3.2.2 in version catalog files |
| codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml | Updated Ktor version from 3.2.1 to 3.2.2 in Maven project configuration |
| project.ihp | Updated "ktor.tree" version attribute from 3.2.1 to 3.2.2 |
| topics/releases.md | Added 3.2.2 release entry and revised formatting/links for previous releases |
| help-versions.json | Updated current version entry from 3.2.1 to 3.2.2 |
| v.list | Updated `ktor_version` variable from 3.2.1 to 3.2.2 |
## Possibly related PRs
- [ktorio/ktor-documentation#647](https://github.com/ktorio/ktor-documentation/pull/647): Updates Ktor versions in the same configuration files, incrementing from 3.1.3 to 3.2.0, showing a related version bump process.
- [ktorio/ktor-documentation#652](https://github.com/ktorio/ktor-documentation/pull/652): Advances Ktor version from 3.2.0 to 3.2.1 in the same files, directly preceding this update to 3.2.2.
- [ktorio/ktor-documentation#616](https://github.com/ktorio/ktor-documentation/pull/616): Updates Ktor version from 3.1.2 to 3.1.3, similar version bump pattern in related files.
## Suggested reviewers
- Stexxe 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
topics/releases.md (1)
284-288
: Version mismatch in row ‘2.1.2’The row header says 2.1.2 but the
<var>
element setsvalue="2.1.3"
.
Search-and-replace likely missed this cell; it will generate an incorrect link target.
♻️ Duplicate comments (2)
codeSnippets/snippets/tutorial-server-websockets/build.gradle.kts (1)
7-8
: As above – consider using a shared version declaration.Same comment as the previous file; pulling from a single source of truth simplifies the next upgrade.
codeSnippets/snippets/engine-main-custom-environment/build.gradle.kts (1)
7-7
: Same duplication comment as above – centralise Ktor plugin version.Repeating literal versions across ~20 snippet scripts is error-prone. Prefer a shared variable / catalog to guarantee consistency in future bumps.
🧹 Nitpick comments (9)
codeSnippets/snippets/tutorial-server-get-started/build.gradle.kts (1)
8-8
: Avoid hard-coding the plugin version
ktor_version
is already provided via project properties; duplicating the literal string risks future drift.- id("io.ktor.plugin") version "3.2.2" + id("io.ktor.plugin") version ktor_versionIf the delegate isn’t visible inside the
plugins {}
block, consider declaring the version once insettings.gradle.kts
’splugins
section or via the version catalog instead.codeSnippets/snippets/tutorial-server-web-application/build.gradle.kts (1)
8-8
: Duplicate literal – recommend centralisingSame comment as in the get-started snippet: use the shared property/catalog to keep the plugin version in sync.
- id("io.ktor.plugin") version "3.2.2" + id("io.ktor.plugin") version ktor_versionThis eliminates manual edits on the next version bump.
codeSnippets/snippets/forwarded-header/build.gradle.kts (1)
7-8
: Plugin version hard-coded in multiple files – consider centralising.The direct literal makes every snippet need a manual edit on each upgrade.
If feasible, pull the version from the rootgradle.properties
or sharedlibs.versions.toml
to reduce churn:- id("io.ktor.plugin") version "3.2.2" + id("io.ktor.plugin") version libs.versions.ktor.get()codeSnippets/snippets/legacy-interactive-website/build.gradle.kts (1)
7-7
: Consider externalizing the plugin version to avoid manual bumps.Hard-coding
"3.2.2"
makes the next upgrade another search-and-replace. Adding a single source of truth (e.g.gradle.properties
, version catalog, or aplugins
block withalias(libs.plugins.ktor)
) keeps all snippets in sync and reduces drift.codeSnippets/snippets/proguard/build.gradle.kts (1)
20-20
: Surface the plugin version via a variable or libs.versions.toml.For the ProGuard snippet too, exposing
ktorPluginVersion
(or using the existing TOML catalog) eliminates manual edits when 3.2.3 ships.codeSnippets/snippets/tutorial-server-docker-compose/build.gradle.kts (1)
11-11
: Align Kotlin-serialization plugin with the Kotlin version property.
org.jetbrains.kotlin.plugin.serialization
is pinned to2.1.20
, while other scripts rely on thekotlin_version
property. To prevent mismatches after a Kotlin upgrade, set:- id("org.jetbrains.kotlin.plugin.serialization") version "2.1.20" + id("org.jetbrains.kotlin.plugin.serialization") version kotlin_version(or migrate both to the version catalog).
topics/releases.md (3)
55-57
: Self-closing anchor may not render as expected
<a href="whats-new-320.md" />
is a self-closing tag with no body text.
If Writerside/Markdown processing expects<a>
…</a>
, the link will be dropped. Consider giving it explicit text, or convert it to a Markdown link for consistency.
141-143
: Minor wording tweakConsider removing the second “improvements” (“with various improvements and bug fixes, including …”) to avoid repetition.
192-194
: Grammar: leading comma produces a fragment“A patch release, including a fix …” reads as a dangling clause.
Drop the comma: “A patch release including a fix …”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
codeSnippets/gradle.properties
(1 hunks)codeSnippets/snippets/aws-elastic-beanstalk/build.gradle.kts
(1 hunks)codeSnippets/snippets/deployment-ktor-plugin/build.gradle.kts
(1 hunks)codeSnippets/snippets/engine-main-custom-environment/build.gradle.kts
(1 hunks)codeSnippets/snippets/forwarded-header/build.gradle.kts
(1 hunks)codeSnippets/snippets/full-stack-task-manager/gradle/libs.versions.toml
(1 hunks)codeSnippets/snippets/htmx-integration/build.gradle.kts
(1 hunks)codeSnippets/snippets/legacy-interactive-website/build.gradle.kts
(1 hunks)codeSnippets/snippets/migrating-express-ktor/gradle.properties
(1 hunks)codeSnippets/snippets/proguard/build.gradle.kts
(1 hunks)codeSnippets/snippets/server-websockets-sharedflow/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-client-kmm/gradle/libs.versions.toml
(1 hunks)codeSnippets/snippets/tutorial-server-db-integration/gradle/libs.versions.toml
(1 hunks)codeSnippets/snippets/tutorial-server-docker-compose/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml
(1 hunks)codeSnippets/snippets/tutorial-server-get-started/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-restful-api/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-routing-and-requests/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-web-application/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-server-websockets/build.gradle.kts
(1 hunks)codeSnippets/snippets/tutorial-website-static/build.gradle.kts
(1 hunks)project.ihp
(1 hunks)topics/releases.md
(6 hunks)
🔇 Additional comments (16)
codeSnippets/gradle.properties (1)
9-9
: Ktor version bump looks good 👍The central property is now aligned with the rest of the repo at
3.2.2
; nothing else to flag here.codeSnippets/snippets/migrating-express-ktor/gradle.properties (1)
1-1
: Consistent version bump acknowledged
ktor_version=3.2.2
matches the root value. No additional feedback.codeSnippets/snippets/tutorial-client-kmm/gradle/libs.versions.toml (1)
5-5
: Version catalog updated correctlyThe catalog now points to Ktor
3.2.2
; dependency aliases below already reference this key, so consumers will pick up the new patch automatically.codeSnippets/snippets/tutorial-server-db-integration/gradle/libs.versions.toml (1)
6-7
: 👍 Catalog entry updated.
ktor-version
now points to3.2.2
; this keeps the version catalog in sync with the Gradle plugin bump. No further action required.codeSnippets/snippets/deployment-ktor-plugin/build.gradle.kts (1)
7-8
: Consistent upgrade acknowledged.Nothing else changed; build logic remains intact.
codeSnippets/snippets/tutorial-server-get-started-maven/pom.xml (1)
11-11
: 👍 Version bump looks correct.
<ktor_version>3.2.2</ktor_version>
propagates automatically to all dependency declarations below.codeSnippets/snippets/full-stack-task-manager/gradle/libs.versions.toml (1)
19-19
: Ktor version bump looks correct and propagates through all catalog referencesUpdating the catalog entry to
3.2.2
automatically aligns everyversion.ref = "ktor"
dependency and plugin across the snippet. No further action needed.codeSnippets/snippets/htmx-integration/build.gradle.kts (1)
7-7
: Plugin version aligned with library – good to mergeBumping the
io.ktor.plugin
to3.2.2
keeps the build script consistent with the catalog update and avoids Gradle “version mismatch” warnings.codeSnippets/snippets/server-websockets-sharedflow/build.gradle.kts (1)
8-8
: Consistent upgrade to 3.2.2 – LGTMThe single-line change cleanly upgrades the Ktor plugin. No further issues spotted.
codeSnippets/snippets/tutorial-server-restful-api/build.gradle.kts (1)
8-8
: Version bump is correct and risk-freeThe plugin version now matches the repository-wide upgrade. Build should remain green.
codeSnippets/snippets/tutorial-server-routing-and-requests/build.gradle.kts (1)
8-8
: Upgrade to 3.2.2 acceptedChange is straightforward; no collateral impact identified.
codeSnippets/snippets/tutorial-website-static/build.gradle.kts (1)
8-8
: Plugin version bump looks correct – please also confirmktor_version
property is updated everywhereThe plugin is now fixed at
3.2.2
, but the build still relies on the project propertyktor_version
for the library artifacts registered below (the plugin auto-fills the version only when the property matches).
Double-check that the rootgradle.properties
(and any version catalogs) was bumped to3.2.2
as well, otherwise you may get a version mismatch at runtime.project.ihp (1)
15-18
: IHP instance version updated—looks goodThe
<instance>
element now points to3.2.2
, keeping the docs in sync with the released artifacts.topics/releases.md (3)
36-44
: Ensure supporting “3.2.2” release-notes topic existsThe table entry correctly introduces 3.2.2, but the include macro later relies on a
docs/topics/release-details/3.2.2.md
(or similar) file referenced byrelease_details_link
.
Please verify that such a topic was added in this PR; otherwise the generated site will contain a broken link.
62-65
: Added context for 3.1.3 – looks fineThe extra detail lines improve clarity and follow the surrounding style.
121-122
: Verify path for migration guide
migrating-3.md
differs from the pattern used elsewhere (e.g.whats-new-320.md
). Make sure the file exists at that exact relative location; otherwise the link will 404 on the site.
releases.md