Skip to content

KTOR-8110 Document deferred session retrieval #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Conversation

vnikolova
Copy link
Collaborator

Copy link

coderabbitai bot commented Jul 16, 2025

Walkthrough

A new section titled "Deferred session retrieval" was added to the server sessions documentation. This section explains the default session retrieval behavior in Ktor and introduces an option to defer session loading by setting a specific system property, providing details on how to enable this optimization.

Changes

File(s) Change Summary
topics/server-sessions.md Added documentation about deferred session retrieval and its configuration via a system property.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vnikolova vnikolova requested a review from bjhham July 16, 2025 15:28
@vnikolova vnikolova self-assigned this Jul 16, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
topics/server-sessions.md (2)

228-228: Add an explicit {id} anchor for consistency with the other sections

All previous top-level subsections specify an {id="…"} anchor. Adding it here keeps the documentation’s deep-link URLs predictable and avoids future broken cross-references.

-## Deferred session retrieval
+## Deferred session retrieval {id="deferred_session_retrieval"}

234-238: Clarify when and how to set the system property

  1. Mention that the property must be set before the embeddedServer { … } block starts so that the plugin picks it up.
  2. Show the more common -D JVM flag alternative, which is easier to use in production than calling System.setProperty in code.
```kotlin
-System.setProperty("io.ktor.server.sessions.deferred", "true")
+// Must be set before starting the server.  
+System.setProperty("io.ktor.server.sessions.deferred", "true")   // in code
+
+// or pass it via the JVM:
+// java -Dio.ktor.server.sessions.deferred=true -jar myapp.jar

This small addition saves readers a round-trip to other docs and prevents subtle “property set too late” issues.

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**


<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 262e4edaaaf432c592ae47f35dff17d34da468ca and e8d478b42aa1f9cac1083d1f841861bd39601539.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `topics/server-sessions.md` (1 hunks)

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@vnikolova vnikolova merged commit 1414264 into main Jul 18, 2025
1 check passed
@vnikolova vnikolova deleted the vnikolova/KTOR-8110 branch July 18, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants