Update kxrpc tutorial to 0.9.1 #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe build configuration for the Kotlin RPC tutorial application was updated to use version 0.9.1 of the Kotlinx RPC plugin and all related dependencies, replacing the previous 0.8.1 versions. No other modifications were made to the build script or dependency declarations. Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts (2)
5-5: Consider externalisingrpcVersionto avoid future driftYou’ve hard-coded
0.9.1here while repeating the same literal further below. Pulling it into a single variable (or the root version catalog) will keep the plugin & libs in sync with one edit next time.- id("org.jetbrains.kotlinx.rpc.plugin") version "0.9.1" + val rpcVersion = "0.9.1" // <-- top-level build-script property + id("org.jetbrains.kotlinx.rpc.plugin") version rpcVersion
17-23: Duplicate literals – extract a singlerpcVersionconstantAll five dependencies repeat the same version string. This is an easy source of mismatch the next time you bump. Re-use the same
rpcVersiondeclared for the plugin:- implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-client:0.9.1") - implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-ktor-client:0.9.1") + implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-client:$rpcVersion") + implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-ktor-client:$rpcVersion") @@ - implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-server:0.9.1") - implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-ktor-server:0.9.1") - implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-serialization-json:0.9.1") + implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-server:$rpcVersion") + implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-ktor-server:$rpcVersion") + implementation("org.jetbrains.kotlinx:kotlinx-rpc-krpc-serialization-json:$rpcVersion")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts(2 hunks)
🔇 Additional comments (1)
codeSnippets/snippets/tutorial-kotlin-rpc-app/build.gradle.kts (1)
5-23: Verify plugin publication location & Kotlin 2.2 compatibilityWe found that:
rpc-plugin-0.9.1.pomisn’t in Maven Central but is published to the Gradle Plugin Portal.- The plugin POM does not declare a
kotlinCompatibilityVersion.Before merging, please ensure:
- You’re resolving the plugin from the Gradle Plugin Portal (default Gradle plugin block).
- The
0.9.1plugin actually supports Kotlin 2.2—for example, by checking its documentation or testing a Kotlin 2.2 sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.