Add Ktor sample with Dagger dependency injection including tests #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @ronshapiro, curious if it's a good solution. |
Contributor
Author
|
@e5l does closing it without a comment mean you don't want this, or you think it's stale? If it's the latter, you just merged the dependent PR after 5.5 years, so I'll need to revise this one on top. |
Member
|
Hey @TWiStErRob, sorry for closing this PR silently. It was almost 6 years after opening, and I thought it would be mean to ask about rebase. I will review the merged sample, update the dependencies, and address any issues that arise. I will be happy for any help :) Thank you for your attention and contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains #62 (first 4 commits), because I based my work on that. Will rebase once that's merged.