Add EventGroupSelectorManager instead of ActorSelectorManager #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
force-pushed
the
marychatte/eventloop
branch
from
25355ef
to
5f423b2
Compare
andrsuh
reviewed
Jun 10, 2024
| val scope = newThreadContext(nThreads = 1).wrapInScope() | ||
|
|
||
| fun run(): Job { | ||
| return scope.launch { runLoop() } |
There was a problem hiding this comment.
What if coroutine completes unexpectedly? Can this lead to the situation where we loose event loops one by one silently? Do we need some completion handler that analyse if the completion was controlled or unexpected, notify about this and resurrect coroutine to maintain the constant number of event loops?
|
@marychatte, could you check the CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.