Update dependency org.apache.httpcomponents.client5:httpclient5 to v5.4 #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
osipxd
force-pushed
the
renovate/apache5
branch
from
f198e77
to
127adc7
Compare
osipxd
reviewed
Oct 11, 2024
| @@ -89,6 +89,8 @@ internal class Apache5Engine(override val config: Apache5EngineConfig) : HttpCli | |||
| ClientTlsStrategyBuilder.create() | |||
| .setSslContext(config.sslContext ?: SSLContexts.createSystemDefault()) | |||
| .setTlsVersions(TLS.V_1_3, TLS.V_1_2) | |||
| // TODO: Remove apply after https://github.com/apache/httpcomponents-client/pull/588 merged | |||
| .apply { setHostnameVerificationPolicy(HostnameVerificationPolicy.BOTH) } | |||
There was a problem hiding this comment.
This option seems the safest one. Tests fail with the default BUILTIN policy. But I need someone to double-check if I'm right
There was a problem hiding this comment.
let's wait for the fix to be released
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.3.1->5.4Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.