-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix libcurl for arm64 #4424
base: main
Are you sure you want to change the base?
Fix libcurl for arm64 #4424
Conversation
I have updated to the libcurl from Understand you may not want to use a random library, to get it, I did the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check if we can replace gnutls version with non GPL alternative? We don't link the library dynamically at the moment (the LGPL library must remain separable)
It does dynamically link to gnu i think. I need the shared libraries and the linker flags to compile my app which uses this Ktor version
I can just build from source, but wasn't sure if that would be alright. Want me to do that again and push it? |
let me try to check if I can do this locally |
but if you can build standalone non-gnu binary, it would be great |
Do you have any preferences to these features:
Personally think, HTTP2 & websockets should probably be added, but other than that, not too sure what would be best |
http2 and http3 would be nice to have |
JFYI: accidentally, yesterday I was decided to check if it possible to build libcurl via Conan :) https://github.com/whyoleg/openssl-builds/actions/runs/11641066156 While the build is green, there are some failures, mostly related to non-desktop targets are built and can be downloaded from artifacts there, or from the link below: https://github.com/whyoleg/openssl-builds/actions/runs/11641066156/artifacts/2136057610 I haven't configured any flags so far, defaults are used. For now, libcurl built there should depend only on openssl and zlib But, I haven't tested, that everything works fine when adding them to the project :) BTW, what Kotlin targets do you think will benefit from static libraries? Or we could use static for all targets? Or we could split curl engine in two artefacts as I've done in cryptography-kotlin? |
Subsystem
Client
Motivation
I couldn't build / link libcurl on arm64 platform. The reason is the one in the repo used a newer version of GCC to compile curl
Solution
I have compiled it with 8.3.3 to match the gcc used in kotlin multiplatform