KTOR-7876 Fix Sink.writeText corrupts long streams for Jetty server #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
requested changes
Dec 5, 2024
| @@ -89,18 +89,14 @@ public fun Source.readTextExactCharacters(charactersCount: Int, charset: Charset | |||
| } | |||
|
|
|||
| /** | |||
| * Writes [text] characters in range \[[fromIndex] .. [toIndex]) with the specified [charset] | |||
| * Writes [text] characters in range [fromIndex] .. [toIndex]) with the specified [charset] | |||
There was a problem hiding this comment.
Could you check the KDoc and mention explicitly included and excluded part of the ranges?
| */ | ||
| public fun Sink.writeText( | ||
| text: CharSequence, | ||
| fromIndex: Int = 0, | ||
| toIndex: Int = text.length, | ||
| charset: Charset = Charsets.UTF_8 | ||
| ) { | ||
| if (charset === Charsets.UTF_8) { | ||
| return writeString(text.toString(), fromIndex, toIndex) |
There was a problem hiding this comment.
Could you tell me why whiteStrings corrupts non ASCII? Should we log this to the kotlinx-io instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Server
Motivation
KTOR-7876 Jetty: respondBytesWriter with writeStringUtf8 corrupts long streams containing non-ascii chars