fix bug：There is a memory leak in this part of the code #89
Conversation
|
Welcome @orsline! It looks like this is your first PR to kubeedge/mappers-go 🎉 |
kubeedge-bot
added
the
size/XS
|
please recommit it with |
|
renew the PR |
|
it is still not signed properly. please |
The image cache is applied in the lib library for transferring images, which needs to be released, otherwise there will be a memory leak 2.Modify data update strategy When the device's desire value is inconsistent with the report value, edgecore will re-deliver the desire value. This judgment will cause the desire value to fail to be delivered, because the desire value saved by the mapper has not changed. Signed-off-by: zhangyanhua <[email protected]>
|
please approve running workflows @fisherxu . thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
kubeedge-bot
added
size/XXL
| @@ -43,10 +43,6 @@ func SyncInfo(dic *di.Container, message mqtt.Message) { | |||
| if i == len(deviceInstances[instanceID].Twins) { | |||
| continue | |||
| } | |||
| // Desired value is not changed. | |||
| if deviceInstances[instanceID].Twins[i].Desired.Value == twinValue { | |||
There was a problem hiding this comment.
why delete this line?
if the desired value is not changed, we should set the value to device.
There was a problem hiding this comment.
The logic processing in this place is not suitable for control message processing, such as controlling the camera to take pictures, one shot is fine, but two shots are not.
Currently, kubeedge does not support independent control messages, so the limitation of this place is removed first.
There was a problem hiding this comment.
If removed, whether it will affect the original processing logic? Can we add some new logic to handle the situation you mentioned?
The image cache is applied in the lib library for transferring images, which needs to be released, otherwise there will be a memory leak