[GSOC] Add validator for feasible space distribution #2404
Conversation
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
gaocegege
There was a problem hiding this comment.
@shashank-iitbhu Could you add a valid distribution so that we can verify the valid case?
Added a test case for valid distribution. |
| parameters: func() []experimentsv1beta1.ParameterSpec { | ||
| ps := newFakeInstance().Spec.Parameters | ||
| ps[0].FeasibleSpace = experimentsv1beta1.FeasibleSpace{ | ||
| Max: "5", | ||
| Min: "1", | ||
| Distribution: experimentsv1beta1.DistributionUniform, | ||
| } | ||
| return ps | ||
| }(), |
There was a problem hiding this comment.
| parameters: func() []experimentsv1beta1.ParameterSpec { | |
| ps := newFakeInstance().Spec.Parameters | |
| ps[0].FeasibleSpace = experimentsv1beta1.FeasibleSpace{ | |
| Max: "5", | |
| Min: "1", | |
| Distribution: experimentsv1beta1.DistributionUniform, | |
| } | |
| return ps | |
| }(), | |
| parameters: newFakeInstance(), |
We already set the valid parameters in the newFakeInstance function, right?
| return ps | ||
| }(), | ||
| wantErr: nil, | ||
| testDescription: "Valid distribution case", |
There was a problem hiding this comment.
| testDescription: "Valid distribution case", | |
| testDescription: "Valid parameters case", |
|
@shashank-iitbhu Could you address lint errors? |
Signed-off-by: Shashank Mittal <[email protected]> validation logic fixed added unit test added unit test for valid distribution requested changes made Update pkg/webhook/v1beta1/experiment/validator/validator.go Co-authored-by: Yuki Iwai <[email protected]> fmt
shashank-iitbhu
force-pushed
the
feat/experiment-validator
branch
from
d891256
to
328559f
Compare
| "k8s.io/apimachinery/pkg/util/validation/field" | ||
|
|
There was a problem hiding this comment.
Could you consolidate this dependency group into the Line 29-35 group?
After you remove the line 28, you run make update.
Signed-off-by: Shashank Mittal <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2374
Checklist: