Skip to content

Conversation

kunal-511
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Update the helm tests to be non blocking when a manifests are updated.

🐛 Related Issues

#3232

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

That is not triggering the test. The goal was to use continue-on-error to or something else to make it non-blocking but still run it.

@kunal-511
Copy link
Contributor Author

That is not triggering the test. The goal was to use continue-on-error to or something else to make it non-blocking but still run it.

It is still triggering the comparison test

@juliusvonkohout
Copy link
Member

That is not triggering the test. The goal was to use continue-on-error to or something else to make it non-blocking but still run it.

It is still triggering the comparison test

not on kustomize changes, but at least it will unblock Matteo
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f86ef35 into kubeflow:master Sep 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants