-
Notifications
You must be signed in to change notification settings - Fork 1k
Add VirtualService conflict troubleshooting for KServe path-based Routing #3247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VirtualService conflict troubleshooting for KServe path-based Routing #3247
Conversation
…ed routing Signed-off-by: madmecodes <[email protected]>
@@ -1,5 +1,19 @@ | |||
# KServe | |||
|
|||
For KServe installation and usage, see the [GitHub Actions tests](.github/workflows/kserve_test.yaml) which demonstrate working configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you list all the tests and explain what they are for? I mean we have already a tests for kserve path based access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or better jus tmerge
kserve_jwt_authentication_test.yaml
kserve_secure_test.yaml
kserve_test.yaml
Into a single file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to find out which ordering makes sense.
Please also merge Into a single file. |
Signed-off-by: madmecodes <[email protected]>
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @juliusvonkohout and @madmecodes, I just saw this. Thanks a lot for covering it! We noticed now that this workaround will lead to problems with cert-manager and the created |
Just out of curiosity, were you able to reproduce it ? I was trying to get it fixed upstream at Istio, but seems like they were not able to reproduce. |
✏️ Summary of Changes
Documents the Istio VirtualService conflict issue that occurs when deploying KServe with path-based routing alongside KubeFlow. Adds troubleshooting guidance to resolve 404 errors caused by conflicts between KubeFlow's wildcard VirtualServices and KServe's specific-host VirtualServices. References upstream Istio issue istio/istio#57404 and provides Gateway configuration workaround.
📦 Dependencies
none
🐛 Related Issues
none
✅ Contributor Checklist