-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix: consolidate multiple kserve test workflows into a single job #3254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: consolidate multiple kserve test workflows into a single job #3254
Conversation
Signed-off-by: madmecodes <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
shall i also merge all the 3 tests file:
|
Yes please, simple and minimalistic. |
Signed-off-by: madmecodes <[email protected]>
Signed-off-by: madmecodes <[email protected]>
selector: | ||
matchLabels: | ||
serving.knative.dev/service: isvc-sklearn-predictor | ||
EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are so many authorizationpolicies in the file and multiple inference services? Is it feasible to reduce the complexity ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you are allowed to use comments for complex stuff that is not directly obvious from the code.
Signed-off-by: madmecodes <[email protected]>
tests/kserve_test.sh
Outdated
fi | ||
|
||
PRIMARY_TOKEN=$(kubectl -n $PRIMARY_NAMESPACE create token default-editor) | ||
ATTACKER_TOKEN=$(kubectl -n $ATTACKER_NAMESPACE create token attacker-sa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually i would like to keep the attacker test.
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
Fixes the improper merge of 3 KServe test workflows by consolidating them into a single job that installs the stack once and runs all tests sequentially.
📦 Dependencies
none
🐛 Related Issues
none
✅ Contributor Checklist