Skip to content

Conversation

madmecodes
Copy link
Contributor

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Fixes the improper merge of 3 KServe test workflows by consolidating them into a single job that installs the stack once and runs all tests sequentially.

📦 Dependencies

none

🐛 Related Issues

none

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@madmecodes
Copy link
Contributor Author

shall i also merge all the 3 tests file:

  • kserve_test.sh
  • knative_authentication_test.sh
  • kserve_jwt_authentication_test.sh

@juliusvonkohout
Copy link
Member

shall i also merge all the 3 tests file:

* kserve_test.sh

* knative_authentication_test.sh

* kserve_jwt_authentication_test.sh

Yes please, simple and minimalistic.

@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Oct 10, 2025
selector:
matchLabels:
serving.knative.dev/service: isvc-sklearn-predictor
EOF
Copy link
Member

@juliusvonkohout juliusvonkohout Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are so many authorizationpolicies in the file and multiple inference services? Is it feasible to reduce the complexity ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you are allowed to use comments for complex stuff that is not directly obvious from the code.

@juliusvonkohout juliusvonkohout changed the title Fix: consolidate kserve test workflows into job Fix: consolidate multiple kserve test workflows into a single job Oct 10, 2025
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Oct 10, 2025
fi

PRIMARY_TOKEN=$(kubectl -n $PRIMARY_NAMESPACE create token default-editor)
ATTACKER_TOKEN=$(kubectl -n $ATTACKER_NAMESPACE create token attacker-sa)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually i would like to keep the attacker test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants