Skip to content

Conversation

@saiadda02
Copy link

@saiadda02 saiadda02 commented Nov 7, 2025

  • Added EMR Serverless hybrid client support with emr-serverless-hybrid:// URL scheme
  • Implemented EMRServerlessHybridClient for real-time S3 event log download and analysis
  • Added EMRServerlessClient and EMRServerlessS3Client for AWS integration
  • Added configuration support for emr_serverless_app_id and region parameters
  • Added analysis tools and reports for production EMR Serverless job optimization
  • Added multiple EMR configuration examples (hybrid, serverless, correct)

cr: https://code.amazon.com/reviews/CR-232997241

🔄 Pull Request

📝 Description

Brief description of changes and motivation.

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

🧪 Testing

  • ✅ All existing tests pass (task test)
  • 🔬 Tested with MCP Inspector
  • 📊 Tested with sample Spark data
  • 🚀 Tested with real Spark History Server (if applicable)

🔬 Test Commands Run

# Example:
# task test
# npx @modelcontextprotocol/inspector uv run -m spark_history_mcp.core.main

🛠️ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

📸 Screenshots (if applicable)

✅ Checklist

  • 🔍 Code follows project style guidelines
  • 🧪 Added tests for new functionality
  • 📖 Updated documentation (README, TESTING.md, etc.)
  • 🔧 Pre-commit hooks pass
  • 📝 Added entry to CHANGELOG.md (if significant change)

📚 Related Issues

Fixes #(issue number)
Related to #(issue number)

🤔 Additional Context


🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

- Added EMR Serverless hybrid client support with emr-serverless-hybrid:// URL scheme
- Implemented EMRServerlessHybridClient for real-time S3 event log download and analysis
- Added EMRServerlessClient and EMRServerlessS3Client for AWS integration
- Added configuration support for emr_serverless_app_id and region parameters
- Added analysis tools and reports for production EMR Serverless job optimization
- Added multiple EMR configuration examples (hybrid, serverless, correct)
- Added architecture documentation and analysis scripts

cr: https://code.amazon.com/reviews/CR-232997241
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nabuskey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nabuskey
Copy link
Collaborator

This PR is too big for us to review realistically. Please:

  1. Remove unnecessary files.
  2. Structure your files to follow the current repository structure.
  3. State exactly what this does and expected end user workflows along with necessary IAM permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants