Skip to content

Conversation

pboyd
Copy link
Member

@pboyd pboyd commented Aug 27, 2025

Description

These are the changes proposed to the catalog API to allow searching and exposing model performance metrics. The tests are failing because no code was generated.

How Has This Been Tested?

N/A

Merge criteria:

  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign al-pragliola for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pboyd pboyd force-pushed the catalog-search-api-spec branch 3 times, most recently from f12b4e4 to 9131a7c Compare August 28, 2025 17:21
@pboyd pboyd force-pushed the catalog-search-api-spec branch 3 times, most recently from a0b8630 to 07342b4 Compare September 4, 2025 18:27
message:
description: Error message
type: string
FilterOption:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also introduce default value if one is available

@pboyd pboyd force-pushed the catalog-search-api-spec branch from 07342b4 to fb1e00b Compare October 1, 2025 12:11
@pboyd pboyd force-pushed the catalog-search-api-spec branch from fb1e00b to 1802f9e Compare October 9, 2025 13:44
@pboyd pboyd force-pushed the catalog-search-api-spec branch from 1802f9e to 71041aa Compare October 9, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants