Skip to content

Conversation

tarilabs
Copy link
Member

Description

We have been asked to also include in the code repository the build time dependencies by using the tool pybuild-deps as a requirements-build.txt file.

How Has This Been Tested?

make install locally.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@tarilabs tarilabs requested a review from jonburdo September 16, 2025 05:21
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tarilabs. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

We have been asked to also include in the code repository
the build time dependencies by using the tool pybuild-deps
as a requirements-build.txt file.

Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20250916-pybuild-deps branch from b6025c3 to b1fb7bd Compare September 22, 2025 06:17
@tarilabs
Copy link
Member Author

(rebased)

@tarilabs tarilabs force-pushed the tarilabs-20250916-pybuild-deps branch from 802ac62 to 5f3e497 Compare September 22, 2025 06:34
Signed-off-by: Matteo Mortari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant