Skip to content

Conversation

syntaxsdev
Copy link
Contributor

Description

Implements GET /api/model_catalog/v1alpha1/models/filter_options endpoint to dynamically provide
available filter options for the UI.

How Has This Been Tested?

  • Added integration tests for repository layer (TestGetFilterableProperties)
  • Added end-to-end tests for catalog layer (TestGetFilterOptions)
  • Added HTTP endpoint tests (TestFindModelsFilterOptions)
  • Existing tests pass

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tomcli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rareddy
Copy link
Contributor

rareddy commented Oct 9, 2025

can rebase without pboyd's commit?

@syntaxsdev syntaxsdev force-pushed the feat/mc-filter-opts branch from 1646c96 to 72bc488 Compare October 9, 2025 19:58
@mturley
Copy link
Contributor

mturley commented Oct 10, 2025

Any updates on this one @syntaxsdev ? I think it's the last big blocker we have on the UI side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants